Ensure vision analysis errors always include exception trace in logs#839
Closed
aydnOktay wants to merge 2 commits intoNousResearch:mainfrom
Closed
Ensure vision analysis errors always include exception trace in logs#839aydnOktay wants to merge 2 commits intoNousResearch:mainfrom
aydnOktay wants to merge 2 commits intoNousResearch:mainfrom
Conversation
Contributor
|
Closing — the code rearrangement moves the availability check later, breaking the fail-fast pattern (downloading/processing images before discovering the client isn't configured). The useful part (adding a log line to the early return) has been applied separately. Thanks for the contribution! |
teknium1
added a commit
that referenced
this pull request
Mar 11, 2026
Previously the early return for unconfigured vision model was silent. Now logs an error so the failure is visible in logs for debugging. Inspired by PR #839 by aydnOktay. Co-authored-by: aydnOktay <aydnOktay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR tightens error logging for the vision analysis tool so that failures are always captured with full exception trace information. When vision_analyze_tool encounters an error, it now uses logger.exception instead of a plain logger.error, guaranteeing that exc_info is populated and making it easier to debug real-world issues as well as satisfy the error-logging tests in tests/tools/test_vision_tools.py